Param vector updates#418
Open
CloneDeath wants to merge 4 commits into
Open
Conversation
Made LocationInitialInfection[] a Vector2.
Added overload for adding Vector2<float> and Vector2<double>.
CloneDeath
requested review from
NeilFerguson,
Z80coder,
dlaydon,
gnedjati,
igfoo,
matt-gretton-dann and
weshinsley
as code owners
| return left + Vector2<double>(right); | ||
| } | ||
| Vector2<double> Geometry::operator+(const Vector2<float> &left, const Vector2<double> &right){ | ||
| return Vector2<double>(left) + right; |
Contributor
There was a problem hiding this comment.
Suggested change
| return Vector2<double>(left) + right; | |
| return right + Vector2<double>(left); |
Uses associativity of addition here. In that case, if you change something in one of the two, you don't have to change the other one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted a couple more fields in Param to BoundingBox.
Converted location of infected to a Vector2.
Simple usage updates (will use more Vector math in a future PR, wanted to keep this one simple).